feat: replace setup.py with pyproject.toml #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienLelaquais
previously approved these changes
Aug 5, 2024
| [tool.setuptools] | ||
| zip-safe = false | ||
|
|
||
| [tool.setuptools.package-data] |
There was a problem hiding this comment.
I don't see the 'taipy/gui/viselements.json' file that is mandatory.
Maybe somewhere else?
There was a problem hiding this comment.
I just put the same files that were referenced in setup.py. Which was only the version.json.
data_files=[("version", ["version.json"])],
We do however have viselements.json from gui and gui_core on the respective MANIFEST.in files for taipy-gui and taipy.
| [tool.setuptools.packages.find] | ||
| include = ["taipy", "taipy.*"] | ||
|
|
||
| [tool.setuptools.package-data] |
There was a problem hiding this comment.
I don't see the 'taipy/gui_core/viselements.json' file that is mandatory.
Maybe somewhere else?
There was a problem hiding this comment.
it should be included by the manifest.in file
joaoandre-avaiga
dismissed stale reviews from dinhlongviolin1, FabienLelaquais, and toan-quach
via
5ad3eff
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
joaoandre-avaiga
force-pushed
the
feature/add-pyproject
branch
6 times, most recently
from
5796a50 to
60f654d
Compare
joaoandre-avaiga
force-pushed
the
feature/add-pyproject
branch
from
60f654d to
a1a3433
Compare
joaoandre-avaiga
force-pushed
the
feature/add-pyproject
branch
from
a1a3433 to
cf322cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.